-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soulifies Backpacks & Duffels #3865
Conversation
take your medicine
Co-authored-by: Theos <[email protected]> Signed-off-by: Sun-Soaked <[email protected]>
technically everything buff but I needed to preserve -some- scaling
The lowered storage for satchels feels a bit worse to play with. The duffels and all that are pretty useful tools now. |
satchel storage wasn't actually changed. check the changed files |
placebo is real |
I may have gaslit myself |
it was bc this actually swaps them to use satchel storage size from backpack storage size |
fuck |
I thought the storage would have been reduced since before duffelbags could only hold four bulky items, but I don't think the amount it could store was changed? EDIT: ignore me i'm stupid, I think duffels should hold less actually edit 2: I commented this on the wrong PR but you saw it anyway: |
top guns should not be tiny size- also duffels have been nerfed since this- a storage object than can hold 5 bulky items can hold 10 normal ones, or 20 small ones, and so on. This only increased the storage of duffels by 1 bulky item, so this was already pretty much an issue |
I have to say, satchel being 4 normal-sized items only feels. Very bad. Like terribly so. |
Satchels now hold 4 normal items. This is painful. |
goongaga
also fixes potential problem with showing messages to correct mob during storage procs
Seems duffelbags can no longer be accessed even on the ground. Rations similarly can no longer be opened. |
issue with an access_check() refactor I did. should be fine now |
Backpacks can't be accessed on the ground. It gives the same message as when you try when it's on your back. |
bottom text
hot take: i think the backpack changes are not good for gameplay at all |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Backpacks and Duffel bags can now carry bulky items, and Duffel bags now have more storage space. Backpacks cannot be opened while worn on your back. Duffels now cannot be opened unless placed on the ground. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game This gives satchel/messenger bag's low storage space an upside(access from back), while justifying putting bigger items in storage objects that really should be able to carry them. Duffel bags are now very well-storage spaced, and can be specialized as a kind of stash bag. Backpack and duffel bags may need to have even more storage space to compensate, but for now I've been pretty frugal in buffing it. It's soul. Soon you will understand my vision <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: balance: Backpacks can now carry Bulky items, but can no longer be accessed while on your back. balance: Duffel bags can now carry more, but must be placed on the ground to be opened. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Sun-Soaked <[email protected]> Co-authored-by: Theos <[email protected]>
About The Pull Request
Backpacks and Duffel bags can now carry bulky items, and Duffel bags now have more storage space.
Backpacks cannot be opened while worn on your back.
Duffels now cannot be opened unless placed on the ground.
Why It's Good For The Game
This gives satchel/messenger bag's low storage space an upside(access from back), while justifying putting bigger items in storage objects that really should be able to carry them.
Duffel bags are now very well-storage spaced, and can be specialized as a kind of stash bag.
Backpack and duffel bags may need to have even more storage space to compensate, but for now I've been pretty frugal in buffing it.
It's soul. Soon you will understand my vision
Changelog
🆑
balance: Backpacks can now carry Bulky items, but can no longer be accessed while on your back.
balance: Duffel bags can now carry more, but must be placed on the ground to be opened.
/:cl: